Re: [I] [Bug][Dora-Cahnge_lead_time_calculator] incorrect linking of commits to deployments when using azuredevops and webhook [incubator-devlake]

Wed, 17 Apr 2024 19:03:25 -0700 


klesh commented on issue #7193:
URL: 
https://github.com/apache/incubator-devlake/issues/7193#issuecomment-2062858278

   > I might be encountering the same bug. If not, please feel free to delete 
this comment as I don't want to stray the discussion.
   > 
   > I created a project with a single Github repo, using the GitHub connection 
for commits and PRs. A webhook is used for deployments. The `DORA Details - 
Lead Time for Changes` board shows the correct PR averages but the `2. PR 
details` table shows a ridiculously high `change_lead_time` (see screenshots). 
It appears to be associating all the PRs in the project to the same and 
currently only webhook commit (notice how the `deployment_id` is the same for 
all PRs).
   > 
   > List of PRs in board: <img alt="image" width="1332" 
src="https://private-user-images.githubusercontent.com/97942514/323215378-16545d1d-3213-4c01-bbfc-902261660822.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTM0MDU4NDEsIm5iZiI6MTcxMzQwNTU0MSwicGF0aCI6Ii85Nzk0MjUxNC8zMjMyMTUzNzgtMTY1NDVkMWQtMzIxMy00YzAxLWJiZmMtOTAyMjYxNjYwODIyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDE4VDAxNTkwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ5YWNkMmIyODgyOTVmMTU3MzZiOGI3M2JkYmIyZGIwODRhNzdkNmJhMTU0OWI5ZjJmODkxYjNlZjg3ZWZlMzImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.QNtHHB2PHkBrXQt6KYz6G58R0LX84EOlY7-uXdhA5As";>
   > 
   > Correct averages: 
![image](https://private-user-images.githubusercontent.com/97942514/323213739-66f5ebb6-a9a7-4cb9-8cd7-c03ac8843173.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTM0MDU4NDEsIm5iZiI6MTcxMzQwNTU0MSwicGF0aCI6Ii85Nzk0MjUxNC8zMjMyMTM3MzktNjZmNWViYjYtYTlhNy00Y2I5LThjZDctYzAzYWM4ODQzMTczLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDE4VDAxNTkwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ1NjMyNjQxZjc4ZTAwMjRjOTcyMWE4MDBmZTc5ZmY5Nzc2YmFjNWJmOGM3MTIwZDE1NzA0YzRhN2E2ZDE0M2MmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.1kDXfIcBXipvO5-WfOJrQ9loYovsOFEf_pRy-j7RzwM)
   > 
   > This is also visible in the `project_pr_metric` table, where all PRs match 
the same deployment_commit_id (in this case the webhook id).
   > 
   > I'm on 1.0.0b4.
   > 
   > Here's the sanitized CURL for the webhook:
   > 
   > ```
   >       "deploymentCommits":[
   >         {
   >         "commit_sha":"<sha>",
   >         "repo_url":"https://github.com/<org>/<repo>"
   >         }
   >       ],
   >       "create_time":"2024-04-11T11:39:33+00:00",
   >       "start_time":"2024-04-11T11:39:33+00:00",
   >     "end_time":"2024-04-16T11:51:35+00:00",
   >     "result": "SUCCESS"
   >      }'
   > ```
   > 
   > Thanks!
   
   Was the deployment the earliest one? If so, it is expected.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to