dosubot[bot] commented on issue #8891: URL: https://github.com/apache/incubator-devlake/issues/8891#issuecomment-4578088740
<!-- Greeting --> Hi @brianfeucht! I'm [Dosu](https://go.dosu.dev/dosubot) and I’m helping the incubator-devlake team. <!-- Answer --> Thanks for the detailed bug report, @brianfeucht. I can confirm all three issues you've identified by looking at the code merged in PR #8877 [[1]](https://github.com/apache/incubator-devlake/pull/8877): 1. **`buildIncidentsQuery`** unconditionally calls `query.Set("filter[service_ids]", serviceId)` — no empty-check, so an empty string gets sent as the filter value and the API returns 0 results for untagged incidents. 2. **`ValidateTaskOptions`** explicitly rejects `ServiceId == ""` with `"not enough info for Rootly execution"`, making it impossible to trigger a global/unfiltered collection today. 3. **The extractor guard** (`containsServiceId`) only skips incidents whose `services.Data` is non-empty *and* doesn't contain the target service — so incidents that somehow do get collected without service associations would pass the guard. But as you noted, they never reach extraction because of bugs 1 and 2. The fix you outlined sounds right: - Make `ServiceId` optional in `ValidateTaskOptions` - Skip `filter[service_ids]` in `buildIncidentsQuery` when `ServiceId` is empty - Skip the `containsServiceId` guard when running a global (unfiltered) collection Since you've indicated willingness to submit a PR, that would be great. One thing to keep in mind: incidents associated with multiple services might get collected more than once if both a global collection and service-scoped collections run — you may want to add a note about idempotency / deduplication behavior in the PR description. <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=reply-with-mention&utm_term=apache%2Fincubator-devlake).* --- Docs are dead. Just use [Dosu](https://dosu.dev?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=static-docs-tagline&utm_term=apache%2Fincubator-devlake). [](https://app.dosu.dev/response-feedback?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=static-docs-feedback&utm_term=apache%2Fincubator-devlake&message_id=b6867344-9456-4098-b15e-77092e3314e5) [](https://github.dosu.com/apache/incubator-devlake?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=static-docs-ask-repo&utm_term=apache%2Fincubator-devlake) [](https://app.dosu.dev/signup?referrer=openSource&source=github-footer&utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=static-docs-share-team&utm_term=apache%2Fincubator-devlake) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
