Le 11/06/15 22:19, Stefan Seelmann a écrit : > On 06/11/2015 12:28 PM, Emmanuel Lécharny wrote: >> Hi guys, >> >> o Some issue has to be fixed when we try to save the config. This is due >> to some delta being computed with some modify being sent when they >> should not. I will review the full process this week. Hopefully, I'll >> get something working soon. > Not sure if this is helpful, or if they can be combined, but we have 3 > code parts the compute diffs of entires: > * PartitionsDiffComputer in openldap.config.editor > * PartitionsDiffComputer in apacheds.config > * Utils.computeDiff() in ldapbrowser.core I had a loo, at the Utils.computeDiff() method, but it's doing a bit too much for my need. Typically, it requires a connection, when I'm expecing to be able to work on simple entries.
Looking at this method, I think we could probably improve it a bit. In the case we are dealing with a server for which we have a schema, the entries will be schema aware, which means we don't have to take care of the Syntax and existing MR : it's alreayd handled by the LDAP API. It definitively needs a review, as it also covers much more than just doing a basic diff (like, managing the ORDERED flag).
