[
https://issues.apache.org/jira/browse/DIRKRB-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14586734#comment-14586734
]
Stefan Seelmann commented on DIRKRB-293:
----------------------------------------
Hi Yaning, here are some suggestions (which also apply to DIRKRB-291,
DIRKRB-292 and DIRKRB-294)
* Please don't construct a DN by concatenating strings. if the UID contains
special characters it may produce an invalid DN. Instead you can use {{new
Dn(new Rdn("uid", uid), BASE_DN)}}.
* Please define and use constants for the LDAP attributes. KerberosAttribute in
ApacheDS kerberos-codec already defines them, so you can copy them from there.
* Instead of repeated {{new DefaultModification()}} please try to create a
helper method.
> Implementing doUpdateIdentity for LdapIdentityBackend
> -----------------------------------------------------
>
> Key: DIRKRB-293
> URL: https://issues.apache.org/jira/browse/DIRKRB-293
> Project: Directory Kerberos
> Issue Type: Sub-task
> Reporter: Xu Yaning
> Assignee: Xu Yaning
> Attachments: DIRKRB-293-v1.patch
>
>
> Impelment {{doUpdateIdentity}} for {{LdapIdentityBackend}} to update an
> identity.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
