[
https://issues.apache.org/jira/browse/DIRSERVER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624866#comment-14624866
]
lucas theisen commented on DIRSERVER-2080:
------------------------------------------
[~akiran], for the most part, the changes look good. I just had a few
questions. First, as this is just a shutdown port, should the default really
be a fixed value ({{10390}}) rather than a dynamically allocated port ({{0}})?
If it is fixed, then whoever uses it would have to ensure that port is not in
use by anything else. Because this value is cached in a file, there is really
no need to use a fixed value. But if it follows our conventions better, then
I'm OK with it. And if we choose to use the fixed port, then we will need to
update the {{apacheds.sh}} appropriately as well.
Which leads me to my second question... The {{service/apacheds.sh}} script is
definitely not the right one. The correct script is
{{installers-maven-plugin/src/main/resources/org/apache/directory/server/installers/archive/apacheds.sh}}.
As I really don't understand the build process I don't know how to fix this.
Whatever builds the {{tar.gz}} or {{zip}} assembly would need to ensure it gets
the right script. If that means {{service/apacheds.sh}}, then we need to copy
it from {{installers-maven-plugin}} (which is WAY more advanced). In that
script, there is a variable for the shutdown port which currently defaults to
{{0}}. If you wanna give me a hint as to how the actual assemblies get built,
I can figure out how to fix this situation.
Finally, I chose to start up the shutdown listener before the service as a
safety measure. Basically, if some shutdown configuration was wrong, or
permissions issue, or any exception is thrown, then the service would not be
started as it would not have a polite way of shutting down. Conversely, we
could add a call to {{stop()}} in the exception handler in the {{start(
String... args )}} method, but that would be unnecessary if we swap the order
back. What do you think?
> Add a way to politely stop apacheds from apacheds.sh
> ----------------------------------------------------
>
> Key: DIRSERVER-2080
> URL: https://issues.apache.org/jira/browse/DIRSERVER-2080
> Project: Directory ApacheDS
> Issue Type: Improvement
> Affects Versions: 2.0.0-M20
> Reporter: lucas theisen
> Fix For: 2.0.0-M21
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
