OK, then I cancel the vote, I will comment and fix the issues tonight.

On June 29, 2016 12:14:07 PM GMT+02:00, "Emmanuel Lécharny" 
<[email protected]> wrote:
>Le 29/06/16 à 00:20, Stefan Seelmann a écrit :
>> Hi all,
>>
>> here is a vote on a new Studio release.
>
>Testing it atm. A few remarks :
>
>* on Mac OSX, there is an issue with the JVM. Since Apple totally
>fucked
>up and decided to not provide anymore a JVM, we have an issue when
>starting Studio. We get a message like "The JVM shared library does not
>contain the JNI_CreateJavaVM symbol". This can be fixed by tuning the
>ApacheDirectoryStudio.app/Contents/Info.plist file, like :
>
>    <array>
>      <!-- to use a specific Java version (instead of the platform's
>default) uncomment one of the following options,
>                                        or add a VM found via
>$/usr/libexec/java_home -V
>        <string>-vm</string>
>       
><string>/System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Commands/java</string>
>
>      -->
>      <!-- The following line has been uncomented and the path to the
>existing JVM added -->
>      <string>-vm</string>
>     
><string>/Library/Java/JavaVirtualMachines/jdk1.8.0_60.jdk/Contents/Home/bin/java</string>
>      <string>-keyring</string>
>      <string>~/.eclipse_keyring</string>
>      <string>-showlocation</string>
>    </array>
>
>This is obviously a real pain in the neck. I think we can get it fixed
>but I don't see how. As soon as we have installers, plus a part in teh
>README telling users how to build the installers, we can simply ignore
>this issue (but it should be documented in teh README and on the web
>site)
>
>
>* The place where the produced packages are put is not correct :
>https://dist.apache.org/repos/dist/dev/directory/studio/2.0.0.v20160628-M11/2.0.0.v20160628-M11/
>instead of
>https://dist.apache.org/repos/dist/dev/directory/studio/2.0.0.v20160628-M11/.
>Not such a big deal, it can be fixed for the next build.
>
>* We don't have the installers to test. Packages for all the platforms
>we suport should be created (.dmg, .deb, .exe, .rpm). I have created
>the
>DMG following the README in the /tools/Mac OS X DMG/README doco, I
>think
>creating all the other installers should be part of the release being
>voted. Note that the installer works well, and teh version it installs
>doe snot have teh same problem I faced upper.
>
>* The copyright licence on the logo is from 2006-2015. It should be
>2016.
>
>* The Notice.txt file has an outdated header too : "Apache Directory
>Studio Copyright 2007-2014 The Apache Software Foundation"
>
>* The LICENSE.txt file needs a serious review :
>- there are mixed license between nlog4j and slf4j :
>
>"Apache Directory Studio bundles a copy of SLF4J API Module, which is
>distributed under the
>following license:
>-------------------------------------------------------------------------------
>    NLOG4J License
>
>Copyright (c) 2004-2006 SLF4J.ORG
>Copyright (c) 2004-2006 QOS.ch
>
>"
>
>- we should include the license for slf4j
>(http://www.slf4j.org/license.html).
>
>Bottom line, all works, but I can't give it a +1 due to those
>annoyances. I can help to get some of those fixed, but feel free to
>comment first.
>
>thanks a lot fo the hard work, Stefan !

Reply via email to