Re: [directory-server] 01/02: Bumped up ehcache version to 3.6.1

[Emmanuel Lécharny]

On 05/01/2019 00:45, Stefan Seelmann wrote:
On 1/4/19 8:05 AM, elecha...@apache.org wrote:
diff --git 
a/kerberos-codec/src/test/java/org/apache/directory/server/kerberos/shared/replay/ReplayCacheImplTest.java
 
b/kerberos-codec/src/test/java/org/apache/directory/server/kerberos/shared/replay/ReplayCacheImplTest.java
index 33d6c2e..1de75b1 100644
--- 
a/kerberos-codec/src/test/java/org/apache/directory/server/kerberos/shared/replay/ReplayCacheImplTest.java
+++ 
b/kerberos-codec/src/test/java/org/apache/directory/server/kerberos/shared/replay/ReplayCacheImplTest.java
@@ -20,20 +20,29 @@
  package org.apache.directory.server.kerberos.shared.replay;
  
  
-import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
  import static org.junit.Assert.assertNull;
  import static org.junit.Assert.assertTrue;
  
+import java.time.Duration;
Just a note, this breaks Java 7 compatibility. I know it's EOL and 8 too
soon, but it still ApacheDS still runs with Java 7. I'm fine with it,
but then let's also update compiler level and documentation. Thoughts?


Ouch, didn't realized that. OTOH, Java 7 is EOL since April 2015 - 
almost 4 years now -.


So, yes, update compiler level and doc is the way to go.


Will do that.


Thanks for the heads up Stefan !