Sorry I should have brought that up at the start! When have you planned to implement jsr-107? Having gone through this exercise, I think abstracting ehcache from the code is a good idea. Also I checked out Caffeine and tested it in my company’s product, so far it seems good as a lightweight local cache fwiw.
-Richard > On Jan 4, 2019, at 7:32 PM, Emmanuel Lécharny <[email protected]> wrote: > > >> On 05/01/2019 00:45, Stefan Seelmann wrote: >>> On 1/4/19 8:05 AM, [email protected] wrote: >>> diff --git >>> a/kerberos-codec/src/test/java/org/apache/directory/server/kerberos/shared/replay/ReplayCacheImplTest.java >>> >>> b/kerberos-codec/src/test/java/org/apache/directory/server/kerberos/shared/replay/ReplayCacheImplTest.java >>> index 33d6c2e..1de75b1 100644 >>> --- >>> a/kerberos-codec/src/test/java/org/apache/directory/server/kerberos/shared/replay/ReplayCacheImplTest.java >>> +++ >>> b/kerberos-codec/src/test/java/org/apache/directory/server/kerberos/shared/replay/ReplayCacheImplTest.java >>> @@ -20,20 +20,29 @@ >>> package org.apache.directory.server.kerberos.shared.replay; >>> -import static org.junit.Assert.assertEquals; >>> +import static org.junit.Assert.assertFalse; >>> import static org.junit.Assert.assertNull; >>> import static org.junit.Assert.assertTrue; >>> +import java.time.Duration; >> Just a note, this breaks Java 7 compatibility. I know it's EOL and 8 too >> soon, but it still ApacheDS still runs with Java 7. I'm fine with it, >> but then let's also update compiler level and documentation. Thoughts? > > > Ouch, didn't realized that. OTOH, Java 7 is EOL since April 2015 - almost 4 > years now -. > > > So, yes, update compiler level and doc is the way to go. > > > Will do that. > > > Thanks for the heads up Stefan ! >
