bdemers commented on code in PR #455:
URL: https://github.com/apache/directory-scimple/pull/455#discussion_r1430398787
##########
scim-server/src/main/java/org/apache/directory/scim/server/configuration/ServerConfiguration.java:
##########
@@ -86,15 +86,15 @@ public SupportedConfiguration
getChangePasswordConfiguration() {
public BulkConfiguration getBulkConfiguration() {
BulkConfiguration bulkConfiguration = new BulkConfiguration();
- bulkConfiguration.setSupported(supportsBulk);
+ bulkConfiguration.setSupported(isSupportsBulk());
bulkConfiguration.setMaxOperations(bulkMaxOperations);
bulkConfiguration.setMaxPayloadSize(bulkMaxPayloadSize);
Review Comment:
Nice suggestion!
To keep this class constant, can you use the getters elsewhere in this class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org
