markusmueller commented on code in PR #455:
URL: https://github.com/apache/directory-scimple/pull/455#discussion_r1430471149
##########
scim-server/src/main/java/org/apache/directory/scim/server/configuration/ServerConfiguration.java:
##########
@@ -86,15 +86,15 @@ public SupportedConfiguration
getChangePasswordConfiguration() {
public BulkConfiguration getBulkConfiguration() {
BulkConfiguration bulkConfiguration = new BulkConfiguration();
- bulkConfiguration.setSupported(supportsBulk);
+ bulkConfiguration.setSupported(isSupportsBulk());
bulkConfiguration.setMaxOperations(bulkMaxOperations);
bulkConfiguration.setMaxPayloadSize(bulkMaxPayloadSize);
Review Comment:
Yes, you are right, I have changed getter usage in all possible cases.
##########
scim-server/src/main/java/org/apache/directory/scim/server/configuration/ServerConfiguration.java:
##########
@@ -86,15 +86,15 @@ public SupportedConfiguration
getChangePasswordConfiguration() {
public BulkConfiguration getBulkConfiguration() {
BulkConfiguration bulkConfiguration = new BulkConfiguration();
- bulkConfiguration.setSupported(supportsBulk);
+ bulkConfiguration.setSupported(isSupportsBulk());
bulkConfiguration.setMaxOperations(bulkMaxOperations);
bulkConfiguration.setMaxPayloadSize(bulkMaxPayloadSize);
Review Comment:
Yes, you are right, I have changed to getter usage in all possible cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
