hboutemy commented on PR #745: URL: https://github.com/apache/directory-scimple/pull/745#issuecomment-2658433399
> I'm starting to go down the path of making sure the sources zip can produce the same binaries as produced from the tag (I realized I haven't tested that yet). he he, you're diving step by step in the right direction, gathering experience: great! Yes, at ASF, one step that is quite specific to us is to not only build from Git tag, but also from ASF official content = source release archive > I remember chatting with you about something similar. I think your advice was to remove this type of configuration from builds. in fact, given we need at ASF to be able to use source release archive to build, without any source control, my advice was not not rely on source control commands during the build: that's for example one reason to store the build timestamp as a property in pom.xml, instead of using git command to extract from last commit. = what you did in this PR > Is that the goal of the [.buildspec](https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/doc/BUILDSPEC.md) the goal of the builspec is to have a declarative way of rebuilding a release: the `rebuild.sh` script can use that declaration to get the source code, prepare expected environment, run the build, and compare with reference sometime, the build gets some data from environment and stores it in output, like such Git info, or detailed JDK version, or JDK vendor, or ...: if (luckily) the detected value can be injected by adding `-Dxxx=value`, we can tweak the build command to simulate the environment that was used by the release manager... I would not call that "the goal of the buildspec", but de-facto, one aspect that the buildspec can cover, because rebuild instructions can be as complex as we wish to overcome any issue we encounter when rebuilding and compare with reference but extracting data from reference build to inject to rebuild command is cumbersome: definitively not funny to do that job when trying to create a buildspec for a release to get the exact reference output HTH -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
