Hi Xiaochun :
question :
DAO UT needs to connect to db or zk，Github action can do it ？
CI/CD is a persistent process
agree the first step is to do a license, spotbugs ，checkstyle , Front-end
eslint check and part UT
—————————————
DolphinScheduler(Incubator) PPMC
Zhanwei Qiao 乔占卫
[email protected]
From: lidong dai<mailto:[email protected]>
Date: 2019-12-10 18:52
To: dev<mailto:[email protected]>; Xiaochun
Liu<mailto:[email protected]>
Subject: Re: [Proposal] Improve CI / CD process
hi xiaochun，
What do you think the hardware configuration of CI server should be？
Best Regards
---------------
DolphinScheduler(Incubator) PPMC
Lidong Dai 代立冬
[email protected]
---------------
Xiaochun Liu <[email protected]> 于2019年12月9日周一 下午11:30写道：
> @ William Guo Wei
> 1、60% is actually not a particularly good ratio. I personally feel that
> 80% should be okay, but considering the current UT situation, I don't dare
> set too high a goal, we can go step by step.
> 2、The AWS in the picture is an example. In fact, it can be any cloud host,
> as long as the external network can access it. The main purpose is to
> trigger the deployment of the demo environment by github action.
> And this is not the goal of the next version for the time being, you can
> ignore it for the time being and evaluate it later.
> 3、License test has been automated for a long time in the github action.
>
> @阿根廷拉
> We use github action tas ci tool, public network built
>
> Xiaochun Liu
> [email protected]
>
>
>
> > 在 2019年12月9日，下午9:46，阿根廷拉 <[email protected]> 写道：
> >
> > Which CI tool to choose, Is the CI locally built or the public
> network built ?
> >
> >
> >
> >
> > ------------------ 原始邮件 ------------------
> > 发件人: "William Guo Wei"<[email protected]>;
> > 发送时间: 2019年12月9日(星期一) 晚上9:29
> > 收件人: "dev"<[email protected]>;
> >
> > 主题: Re: [Proposal] Improve CI / CD process
> >
> >
> >
> > Very good proposal! Very glad to see new proposal after meetup.
> > Here are some questions:
> > 1. About the bar of UT. I thought now UT is below 40%, totally agree to
> improve that. Other people opinion?
> > 2. I noticed that you mentioned some AWS Servers to support this CICD
> process. How many extra resource besides Apache offered do you need if we
> want to finish this CICD.
> > 3. I am curious about license check. Do we have some way to do it
> automatically or semi-auto way?
> >
> >
> >
> > William Guo Wei
> >
> >
> > ------------------ Original ------------------
> > From: Xiaochun Liu <[email protected]>
> > Date: Mon,Dec 9,2019 8:47 PM
> > To: dev <[email protected]>
> > Subject: Re: [Proposal] Improve CI / CD process
> >
> >
> >
> >
> >
> > Hi,
> > all, the CI / CD process in DolphinScheduler only has build check
> and license check. The other parts are missing now.
> >
> >
> > Here is my proposal:
> > The overall idea of CI / CD is shown in the following graph. There are
> two main triggering methods, submitting PR / MR trigger and night time
> trigger. The night time trigger triggers to run once a day, and the task is
> relatively heavy.
> >
> > The content of CI / CD to be tested or checked is shown in the graph
> below.
> >
> >
> >
> >
> >
> > The above is my overall thinking. The details of the CI / CD plan for
> the next version are as follows:
> > 1) The ut needs to be improved. The goal of the proportion of UT
> is to reach 60%. At least the newly added PR cannot be lower than this. If
> it feels unreasonable, we can vote to discuss it. The modules involved in
> this supplementary UT are api server, common, alert, and some master and
> worker UTs.
> > 2) checkstyle check, there are two kinds of google and Alibaba,
> personal preference is alibaba (more comprehensive), this can be discussed
> separately
> > 3) spotbugs check
> > 4) Front-end eslint check
> > 5) Coveralls code coverage report. When submitting a PR, it will
> be automatically displayed in the comments, showing the impact of the new
> part on the current code coverage, and the current test coverage will be
> displayed on the github home page.
> >
> >
> > If have other ideas, we can discuss together ~~ Thank you
> >
> > Xiaochun Liu
> > [email protected]
>
>
