Ok, thanks for your reminding, and it’s not a serious issue, we will discuss about it in another way.
Best Regards --------------- DolphinScheduler(Incubator) Committer Xiaochun Liu 刘小春 [email protected] --------------- > 在 2019年12月18日，下午4:06，Sheng Wu <[email protected]> 写道： > > Xiaochun Liu <[email protected]> 于2019年12月18日周三 下午3:30写道： > >> Now service unit test need mock or database, so we vote to chose one. If >> you prefer mock, pls vote +1, other wise -1, thank you. >> > > Hi Xiaochun > > If you want a vote, please use different thread, the title should start > with [VOTE]. > In the Apache, only very serious issues use the vote to make discussion. > > Sheng Wu 吴晟 > Twitter, wusheng1108 > >> >> >> >> >> Best Regards >> --------------- >> DolphinScheduler(Incubator) Committer >> Xiaochun Liu 刘小春 >> [email protected] >> --------------- >> >> >> >>> 在 2019年12月13日，上午1:02，Xiaochun Liu <[email protected]> 写道： >>> >>> The root issue link: >> https://github.com/apache/incubator-dolphinscheduler/issues/1460 < >> https://github.com/apache/incubator-dolphinscheduler/issues/1460> >>> >>> Best Regards >>> --------------- >>> DolphinScheduler(Incubator) Committer >>> Xiaochun Liu 刘小春 >>> [email protected] <mailto:[email protected]> >>> --------------- >>> >>> >>> >>>> 在 2019年12月13日，上午12:21，Xiaochun Liu <[email protected] <mailto: >> [email protected]>> 写道： >>>> >>>> To all: >>>> >>>> So far, no one has objected to the UT coverage rate, so we will >> implement it according to the 60% UT coverage rate. >>>> When pmc or committer merge pr, pay attention to the codecov comments. >> We must ensure that the UT coverage rate >>>> of the submitted PR files reach 60%, and it is guaranteed that the UT >> coverage rate will only increase after the PR is merged. >>>> >>>> And I will create a root issue to track the ci/cd process later. >>>> >>>> I will break it into many scattered issues for everyone to contribute >> under the root issue: >>>> 1、ut >>>> 2、checkstyle check >>>> 3、spotbugs check >>>> 4、Front-end eslint check >>>> 5、The CI / CD inspection and requirements are written into the >> code contribution document, >>>> the new PR code ut coverage is required to reach 60%, and >> the coverage can only be increased, not reduced. >>>> 6、We use codecov tool to replace coveralls tool in fact, and this >> job is done. >>>> >>>> >>>> >>>> Best Regards >>>> --------------- >>>> DolphinScheduler(Incubator) Committer >>>> Xiaochun Liu 刘小春 >>>> [email protected] <mailto:[email protected]> >>>> --------------- >>>> >>>> >>>> >>>>> 在 2019年12月12日，上午11:51，Xiaochun Liu <[email protected] <mailto: >> [email protected]>> 写道： >>>>> >>>>> To chenxingchun: >>>>> Github action supply virtual machine, you can do what you want. The >> link is: >>>>> >> https://help.github.com/en/actions/automating-your-workflow-with-github-actions/virtual-environments-for-github-hosted-runners >> < >> https://help.github.com/en/actions/automating-your-workflow-with-github-actions/virtual-environments-for-github-hosted-runners >>> >>>>> Pls learn about it, thanks. >>>>> >>>>> Best Regards >>>>> --------------- >>>>> DolphinScheduler(Incubator) Committer >>>>> Xiaochun Liu 刘小春 >>>>> [email protected] <mailto:[email protected]> >>>>> --------------- >>>>> >>>>> >>>>> >>>>>> 在 2019年12月11日，上午11:12，陈兴春 <[email protected] <mailto: >> [email protected]>> 写道： >>>>>> >>>>>> I want to know how github actions execute api test and performance >> test, whether to send test reports, how to set environment variables in the >> interface >>>>> >>>> >>> >> >>
