+1 binding, all looks good to me. Agree with Wu Sheng; Apache software doesn't add includes other apache software in the notice.
Best regards, Shaofeng Shi 史少锋 Apache Kylin PMC Email: [email protected] Apache Kylin FAQ: https://kylin.apache.org/docs/gettingstarted/faq.html Join Kylin user mail group: [email protected] Join Kylin dev mail group: [email protected] [email protected] <[email protected]> 于2020年2月18日周二 下午5:45写道： > Thanks for that issue. > Does it means the following is right? > Such as hadoop and zookeeper, they also are a part of ASF > already,So I can remove the notice of them in next release too. > > > > DolphinScheduler(Incubator) PPMC > Gang Li 李岗 > > [email protected]<mailto:[email protected]> > > From: Sheng Wu > Date: 2020-02-18 16:01 > To: dev > Subject: Re: [VOTE] Release Apache DolphinScheduler (Incubating) 1.2.1 > +1 binding > > ACS checked > SHA512 exists > compiling passed > DECLAIMER exists > LICENSE and NOTICE exist > name includes incubating > > A small issue you could fix in the next release. > > The Apache standard NOTICE could be excluded in the NOTICE, to make the > NOTICE file smaller > Such as, > Does Apache I18n means Apache Common i18n? If yes, this is a part of ASF > already, you don't need the following texts. > ``` > ========================================================================= > > > ApacheDS I18n NOTICE > > ========================================================================= > ApacheDS I18n > Copyright 2003-2013 The Apache Software Foundation > > This product includes software developed at > The Apache Software Foundation (http://www.apache.org/). > ``` > > Sheng Wu 吴晟 > Twitter, wusheng1108 > > > [email protected] <[email protected]> 于2020年2月11日周二 > 下午8:12写道： > > > > > Hello DolphinScheduler Community, > > > > This is a call for vote to release Apache DolphinScheduler (Incubating) > > version 1.2.1 > > > > Release notes: > > > > > https://github.com/apache/incubator-dolphinscheduler/blob/1.2.1/ReleaseNotes.md > > > > The release candidates: > > https://dist.apache.org/repos/dist/dev/incubator/dolphinscheduler/1.2.1/ > > > > Maven 2 staging repository: > > > > > https://repository.apache.org/content/repositories/orgapachedolphinscheduler-1018/org/apache/dolphinscheduler/ > > > > Git tag for the release: > > https://github.com/apache/incubator-dolphinscheduler/tree/1.2.1 > > > > Release Commit ID: > > > > > https://github.com/apache/incubator-dolphinscheduler/commit/84a4f50caa4f0ea2abdeb0ea12c10f2f4b3f6907 > > > > Keys to verify the Release Candidate: > > https://dist.apache.org/repos/dist/dev/incubator/dolphinscheduler/KEYS > > > > Look at here for how to verify this release candidate: > > https://dolphinscheduler.apache.org/en-us/docs/development/release.html > > > > The vote will be open for at least 72 hours or until necessary number of > > votes are reached. > > > > Please vote accordingly: > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove with the reason > > > > Checklist for reference: > > > > [ ] Download links are valid. > > > > [ ] Checksums and PGP signatures are valid. > > > > [ ] DISCLAIMER is included. > > > > [ ] Source code artifacts have correct names matching the current > release. > > > > [ ] LICENSE and NOTICE files are correct for each DolphinScheduler repo. > > > > [ ] All files have license headers if necessary. > > > > [ ] No compiled archives bundled in source archive. > > > > More detail checklist please refer: > > > > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > > > DolphinScheduler(Incubator) PPMC > > Gang Li 李岗 > > > > [email protected]<mailto:[email protected]> > > >
