imay commented on a change in pull request #285: Fix BE can't be grayscale
upgraded
URL: https://github.com/apache/incubator-doris/pull/285#discussion_r231089810
##########
File path: be/src/runtime/lib_cache.cpp
##########
@@ -126,10 +126,11 @@ LibCache::LibCacheEntry::~LibCacheEntry() {
Status LibCache::get_so_function_ptr(
const std::string& hdfs_lib_file, const std::string& symbol,
void** fn_ptr, LibCacheEntry** ent, bool quiet) {
+ const std::string& real_symbol = get_real_symbol(symbol);
Review comment:
you can change argument symbol to origin_symbol, then you needn't change
following symbol to real_symbol
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
