imay commented on a change in pull request #285: Fix BE can't be grayscale
upgraded
URL: https://github.com/apache/incubator-doris/pull/285#discussion_r231354309
##########
File path: be/src/runtime/lib_cache.h
##########
@@ -161,6 +162,15 @@ class LibCache {
const std::string& hdfs_lib_file, LibType type,
boost::unique_lock<boost::mutex>* entry_lock, LibCacheEntry** entry);
+ // map "palo" to "doris" in symbol, only for grayscale upgrading
+ std::string get_real_symbol(const std::string& symbol) {
+ std::regex rx1("8palo_udf");
Review comment:
I think std::regex constructor may be cost, so I suggest declare rx1 and rx2
variable static.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
