morningman commented on a change in pull request #333: Add distributor which
allocate task to be fairly
URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235339798
##########
File path:
fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadScheduler.java
##########
@@ -45,7 +46,7 @@ protected void runOneCycle() {
LOG.debug("there are {} job need scheduler",
routineLoadJobList.size());
for (RoutineLoadJob routineLoadJob : routineLoadJobList) {
// judge nums of tasks more then max concurrent tasks of cluster
- List<RoutineLoadTask> routineLoadTaskList = null;
+ List<RoutineLoadTaskInfo> routineLoadTaskList = null;
try {
routineLoadJob.writeLock();
Review comment:
use routineLoadJob.writeLock() to protect is weird.
And lock should be used as (lock() is outside the try{}):
lock();
try {
} finally {
unlock();
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
