morningman commented on a change in pull request #333: Add distributor which
allocate task to be fairly
URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235327570
##########
File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoad.java
##########
@@ -251,6 +355,31 @@ public void updateRoutineLoadJobState(RoutineLoadJob
routineLoadJob, RoutineLoad
}
}
+ public void processTimeOutTasks() {
+ List<RoutineLoadTaskInfo> runningTasks = new
ArrayList<>(idToRoutineLoadTask.values());
+ runningTasks.removeAll(needSchedulerRoutineLoadTask);
+
+ for (RoutineLoadTaskInfo routineLoadTaskInfo : runningTasks) {
+ routineLoadTaskInfo.writeLock();
Review comment:
And I can't see why you need a lock here?
Nothing need to be protected in RoutineLoadTaskInfo?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
