chaoyli commented on a change in pull request #516: Modify compaction code to
be adapted to Rowset interface
URL: https://github.com/apache/incubator-doris/pull/516#discussion_r246615834
##########
File path: be/src/olap/cumulative_compaction.cpp
##########
@@ -462,12 +460,12 @@ OLAPStatus
CumulativeCompaction::_do_cumulative_compaction() {
return res;
}
-OLAPStatus CumulativeCompaction::_update_header(vector<SegmentGroup*>*
unused_indices) {
- vector<SegmentGroup*> new_indices;
- new_indices.push_back(_new_segment_group);
+OLAPStatus CumulativeCompaction::_update_header(vector<RowsetSharedPtr>*
unused_indices) {
+ vector<RowsetSharedPtr> new_indices;
+ new_indices.push_back(_rowset);
OLAPStatus res = OLAP_SUCCESS;
- res = _tablet->replace_data_sources(&_need_merged_versions, &new_indices,
unused_indices);
+ res = _tablet->modify_rowsets(&_need_merged_versions, &new_indices,
unused_indices);
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
