chaoyli commented on a change in pull request #516: Modify compaction code to
be adapted to Rowset interface
URL: https://github.com/apache/incubator-doris/pull/516#discussion_r246649906
##########
File path: be/src/olap/merger.h
##########
@@ -29,23 +29,25 @@ class ColumnData;
class Merger {
public:
// parameter index is created by caller, and it is empty.
- Merger(TabletSharedPtr tablet, SegmentGroup* index, ReaderType type);
+ //Merger(TabletSharedPtr tablet, RowsetSharedPtr rowset, ReaderType type);
+ Merger(TabletSharedPtr tablet, RowsetBuilder* builder, ReaderType type);
virtual ~Merger() {};
// @brief read from multiple OLAPData and SegmentGroup, then write into
single OLAPData and SegmentGroup
// @return OLAPStatus: OLAP_SUCCESS or FAIL
// @note it will take long time to finish.
- OLAPStatus merge(const std::vector<ColumnData*>& olap_data_arr,
- uint64_t* merged_rows, uint64_t* filted_rows);
+ OLAPStatus merge(const std::vector<RowsetReaderSharedPtr>& rs_readers,
+ const Version& version, uint64_t* merged_rows, uint64_t*
filted_rows);
// 获取在做merge过程中累积的行数
uint64_t row_count() {
return _row_count;
}
private:
TabletSharedPtr _tablet;
- SegmentGroup* _segment_group;
+ //RowsetSharedPtr _rowset;
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
