chaoyli commented on a change in pull request #536: Add Rowset and 
RowsetBuilder for PushHandler
URL: https://github.com/apache/incubator-doris/pull/536#discussion_r248944714
 
 

 ##########
 File path: be/src/olap/push_handler.cpp
 ##########
 @@ -73,13 +125,13 @@ OLAPStatus PushHandler::process_realtime_push(
 
         // if push finished, report success to fe
         if (tablet->has_pending_data(request.transaction_id)) {
 
 Review comment:
   Tablet will has no pending message. You should get it from transaction 
manager.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to