chaoyli commented on a change in pull request #536: Add Rowset and
RowsetBuilder for PushHandler
URL: https://github.com/apache/incubator-doris/pull/536#discussion_r248946296
##########
File path: be/src/olap/push_handler.cpp
##########
@@ -454,13 +443,13 @@ OLAPStatus PushHandler::_convert(
break;
}
}
-
- SchemaChangeHandler schema_change;
- res = schema_change.schema_version_convert(
- curr_tablet,
- new_tablet,
- curr_olap_indices,
- new_olap_indices);
+ // TODO(hkp): modify schema change
+ //SchemaChangeHandler schema_change;
+ //res = schema_change.schema_version_convert(
+ // curr_tablet,
+ // new_tablet,
+ // curr_olap_indices,
+ // new_olap_indices);
if (res != OLAP_SUCCESS) {
OLAP_LOG_WARNING("failed to change schema version for delta."
Review comment:
LOG(WARNING)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]