chaoyli commented on a change in pull request #575: realize rowset remove api
URL: https://github.com/apache/incubator-doris/pull/575#discussion_r251313240
##########
File path: be/src/olap/rowset/alpha_rowset.cpp
##########
@@ -117,9 +136,13 @@ int64_t AlphaRowset::start_version() const {
return _rowset_meta->version().first;
}
-bool AlphaRowset::create_hard_links(std::vector<std::string>* success_links) {
+bool AlphaRowset::create_files_with_new_name(std::vector<std::string>*
success_links) {
Review comment:
make_snapshot will be better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
