kangpinghuang commented on a change in pull request #643: Import TabletState
and remove mutex in TabletMeta
URL: https://github.com/apache/incubator-doris/pull/643#discussion_r258308728
##########
File path: be/src/olap/tablet.cpp
##########
@@ -73,8 +56,8 @@ TabletSharedPtr Tablet::create_from_tablet_meta_file(
// add new fields
boost::filesystem::path file_path_path(file_path);
- std::string shard_path =
file_path_path.parent_path().parent_path().parent_path().string();
- std::string shard_str = shard_path.substr(shard_path.find_last_of('/') +
1);
+ string shard_path =
file_path_path.parent_path().parent_path().parent_path().string();
+ string shard_str = shard_path.substr(shard_path.find_last_of('/') + 1);
Review comment:
you delete using std::string, can this be compiled?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
