kangpinghuang commented on a change in pull request #643: Import TabletState
and remove mutex in TabletMeta
URL: https://github.com/apache/incubator-doris/pull/643#discussion_r258306002
##########
File path: be/src/olap/tablet_meta.h
##########
@@ -123,80 +166,55 @@ class TabletMeta {
DelPredicateArray delete_predicates() const;
bool version_for_delete_predicate(const Version& version);
- inline const int64_t table_id() const;
- inline const int64_t partition_id() const;
- inline const int64_t tablet_id() const;
- inline const int64_t schema_hash() const;
- inline const int16_t shard_id() const;
- void set_shard_id(int32_t shard_id);
- inline int64_t creation_time() const;
- void set_creation_time(int64_t creation_time);
-
- inline const size_t num_rows() const;
- inline const size_t data_size() const;
- inline const size_t version_count() const;
- Version max_version() const;
-
- inline const TabletState& tablet_state() const;
inline const AlterTabletTask& alter_task() const;
inline AlterTabletTask* mutable_alter_task();
OLAPStatus add_alter_task(const AlterTabletTask& alter_task);
OLAPStatus delete_alter_task();
- inline int32_t cumulative_layer_point() const;
- void set_cumulative_layer_point(int32_t new_point);
- inline const TabletSchema& tablet_schema() const;
- inline void set_data_dir(DataDir* data_dir);
private:
- int64_t _table_id;
- int64_t _partition_id;
- int64_t _tablet_id;
- int64_t _schema_hash;
- int16_t _shard_id;
-
- int64_t _creation_time;
- int32_t _cumulative_layer_point;
-
+ TabletState _tablet_state;
TabletSchema _schema;
+
vector<RowsetMetaSharedPtr> _rs_metas;
vector<RowsetMetaSharedPtr> _inc_rs_metas;
DelPredicateArray _del_pred_array;
- TabletState _tablet_state;
AlterTabletTask _alter_task;
- TabletMetaPB _tablet_meta_pb;
DataDir* _data_dir;
-
- mutable std::mutex _mutex;
+ TabletMetaPB _tablet_meta_pb;
Review comment:
where to init this PB?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
