kangpinghuang commented on a change in pull request #669: Convert old files
when start be
URL: https://github.com/apache/incubator-doris/pull/669#discussion_r261909773
##########
File path: be/src/olap/rowset/alpha_rowset.cpp
##########
@@ -61,12 +61,6 @@ OLAPStatus AlphaRowset::copy(RowsetWriter*
dest_rowset_writer) {
}
OLAPStatus AlphaRowset::remove() {
- OlapMeta* meta = _data_dir->get_meta();
- OLAPStatus status = RowsetMetaManager::remove(meta, rowset_id());
- if (status != OLAP_SUCCESS) {
- LOG(FATAL) << "failed to remove meta of rowset_id:" << rowset_id();
- return status;
- }
Review comment:
We should make sure that we should remove rowset meta first and then remove
related segment groups
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
