kangpinghuang commented on a change in pull request #669: Convert old files
when start be
URL: https://github.com/apache/incubator-doris/pull/669#discussion_r261956006
##########
File path: be/src/olap/rowset/alpha_rowset.h
##########
@@ -77,8 +77,14 @@ class AlphaRowset : public Rowset {
int64_t ref_count() const override;
- virtual OLAPStatus make_snapshot(const std::string& snapshot_path,
- std::vector<std::string>* success_files);
+ OLAPStatus make_snapshot(const std::string& snapshot_path,
+ std::vector<std::string>* success_files);
Review comment:
this function is a virtual function. Should use override like this:
OLAPStatus make_snapshot(const std::string& snapshot_path,
std::vector<std::string>* success_files)
override;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
