yiguolei commented on a change in pull request #669: Convert old files when 
start be
URL: https://github.com/apache/incubator-doris/pull/669#discussion_r261940754
 
 

 ##########
 File path: be/src/olap/tablet_meta_manager.cpp
 ##########
 @@ -78,9 +76,9 @@ OLAPStatus TabletMetaManager::get_json_header(DataDir* store,
 }
 
 OLAPStatus TabletMetaManager::save(DataDir* store,
-        TTabletId tablet_id, TSchemaHash schema_hash, const TabletMeta* 
tablet_meta) {
+        TTabletId tablet_id, TSchemaHash schema_hash, const TabletMeta* 
tablet_meta, string header_prefix) {
 
 Review comment:
   it should be header prefix because the const variable's name is header 
prefix and meta is too broad.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to