yiguolei commented on a change in pull request #669: Convert old files when
start be
URL: https://github.com/apache/incubator-doris/pull/669#discussion_r261940832
##########
File path: be/src/olap/tablet_meta_manager.h
##########
@@ -34,13 +38,16 @@ class TabletMetaManager {
static OLAPStatus get_json_header(DataDir* store, TTabletId tablet_id,
TSchemaHash schema_hash, std::string* json_header);
- static OLAPStatus save(DataDir* store, TTabletId tablet_id, TSchemaHash
schema_hash, const TabletMeta* tablet_meta);
- static OLAPStatus save(DataDir* store, TTabletId tablet_id, TSchemaHash
schema_hash, const std::string& meta_binary);
+ static OLAPStatus save(DataDir* store, TTabletId tablet_id, TSchemaHash
schema_hash,
+ const TabletMeta* tablet_meta, string header_prefix
= "tablet_meta_");
Review comment:
Mr zhao said we could use default argument.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
