imay commented on a change in pull request #764: Convert next_row interface to
next_block
URL: https://github.com/apache/incubator-doris/pull/764#discussion_r268469195
##########
File path: be/src/olap/rowset/alpha_rowset_reader.cpp
##########
@@ -29,18 +29,13 @@ AlphaRowsetReader::AlphaRowsetReader(
_rowset(rowset),
_key_range_size(0) {
_alpha_rowset_meta = reinterpret_cast<AlphaRowsetMeta*>(rowset_meta);
- Version version = _alpha_rowset_meta->version();
- if (version.first == version.second) {
- _is_cumulative_rowset = false;
- } else {
- _is_cumulative_rowset = true;
- }
}
AlphaRowsetReader::~AlphaRowsetReader() {
for (auto& row_cursor : _row_cursors) {
- delete row_cursor;
+ SAFE_DELETE(row_cursor);
Review comment:
Don't use SAFE_DELETE, because `delete nullptr` has no harm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
