imay commented on a change in pull request #764: Convert next_row interface to
next_block
URL: https://github.com/apache/incubator-doris/pull/764#discussion_r269507918
##########
File path: be/src/olap/rowset/alpha_rowset_reader.h
##########
@@ -27,25 +27,38 @@
namespace doris {
+struct MergeContext {
+ std::shared_ptr<ColumnData> column_data = nullptr;
+
+ int key_range_index = -1;
+
+ // Read data from ColumnData for the first time.
+ // ScanKey should be sought in this case.
+ bool first_read_symbol = true;
+
+ // For singleton Rowset, there are several SegmentGroups
+ // Each of SegmentGroups correponds to a row_block upon scan
+ RowBlock* row_block = nullptr;
+
+ // For singleton Rowset, there are several SegmentGroups
+ // Each of SegmentGroups correponds to a row_cursor
+ std::shared_ptr<RowCursor> row_cursor = nullptr;
Review comment:
`unique_ptr` is enough
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
