kangpinghuang commented on a change in pull request #806: Add creation time in
txn manager
URL: https://github.com/apache/incubator-doris/pull/806#discussion_r268516768
##########
File path: be/src/olap/txn_manager.cpp
##########
@@ -409,29 +409,38 @@ bool TxnManager::has_committed_txn(TPartitionId
partition_id, TTransactionId tra
if (load_itr != it->second.end()) {
// found load for txn,tablet
// case 1: user commit rowset, then the load id must be equal
- std::pair<PUniqueId, RowsetSharedPtr>& load_info =
load_itr->second;
- if (load_info.second != NULL) {
+ TabletTxnInfo& load_info = load_itr->second;
+ if (load_info.rowset != NULL) {
return true;
}
}
}
return false;
}
-bool TxnManager::get_expire_txns(TTabletId tablet_id, std::vector<int64_t>*
transaction_ids) {
- /*
+bool TxnManager::get_expire_txns(TTabletId tablet_id, SchemaHash schema_hash,
std::vector<int64_t>* transaction_ids) {
+ if (transaction_ids == nullptr) {
+ LOG(WARNING) << "parameter is null when get_expire_txns by tablet";
+ return false;
+ }
time_t now = time(NULL);
Review comment:
NULL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
