kangpinghuang commented on a change in pull request #806: Add creation time in
txn manager
URL: https://github.com/apache/incubator-doris/pull/806#discussion_r268517431
##########
File path: be/src/olap/txn_manager.h
##########
@@ -48,6 +48,22 @@
namespace doris {
+struct TabletTxnInfo {
+ PUniqueId load_id;
+ RowsetSharedPtr rowset;
+ int64_t creation_time;
+
+ TabletTxnInfo(
+ PUniqueId load_id,
+ RowsetSharedPtr rowset) :
+ load_id(load_id),
+ rowset(rowset) {
+ creation_time = time(NULL);
Review comment:
the name is the same:load_id(load_id)? IS there no problems?
and creation_time can also be put in initialization list,
create_time(time(nullptr))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
