imay commented on a change in pull request #1202: Add max cache size to
ClientCache in BE
URL: https://github.com/apache/incubator-doris/pull/1202#discussion_r287294679
##########
File path: be/src/runtime/client_cache.cpp
##########
@@ -201,6 +212,14 @@ void ClientCacheHelper::test_shutdown() {
}
}
+int ClientCacheHelper::get_cache_size() {
Review comment:
this is a bad implementation, every time you would iterator the list and get
a size which is a O(n) complex.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
