imay commented on a change in pull request #1202: Add max cache size to
ClientCache in BE
URL: https://github.com/apache/incubator-doris/pull/1202#discussion_r287297438
##########
File path: be/src/runtime/client_cache.h
##########
@@ -108,6 +112,9 @@ class ClientCacheHelper {
// MetricRegistry
bool _metrics_enabled;
+ // max connections in this cache, -1 means unlimited
+ int _max_cache_size;
Review comment:
I think you have a max cache size for all connection is bad. this should
used for each endpoint. If one cluster has 100 backends. there is at least one
connection for each, which is 100 as total.
So, I think you should rethink about this, and reimplement it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
