imay commented on a change in pull request #1204: Support arbitrary kafka
properties
URL: https://github.com/apache/incubator-doris/pull/1204#discussion_r287684683
##########
File path: be/src/runtime/routine_load/data_consumer.cpp
##########
@@ -72,6 +72,13 @@ Status KafkaDataConsumer::init(StreamLoadContext* ctx) {
RETURN_IF_ERROR(set_conf("api.version.request", "true"));
RETURN_IF_ERROR(set_conf("api.version.fallback.ms", "0"));
+ for(auto item : ctx->kafka_info->properties) {
Review comment:
I think you should parse this property in FE, and pass the only needed
properties.
For example, "property.abc" is changed to "abc" by FE. And then FE pass it
to BE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
