imay commented on a change in pull request #1204: Support arbitrary kafka
properties
URL: https://github.com/apache/incubator-doris/pull/1204#discussion_r287686336
##########
File path:
fe/src/main/java/org/apache/doris/analysis/CreateRoutineLoadStmt.java
##########
@@ -394,6 +400,17 @@ private void checkKafkaProperties() throws
AnalysisException {
}
}
}
+ // check custom kafka property
+ for (Map.Entry<String, String> dataSourceProperty :
dataSourceProperties.entrySet()) {
+ if (dataSourceProperty.getKey().startsWith("property.")) {
+ String propertyValueArr[] =
dataSourceProperty.getKey().split("\\.");
+ if (propertyValueArr.length < 2) {
+ throw new AnalysisException("kafka property value could
not be a empty string");
+ }
+ customKafkaProperties.put(dataSourceProperty.getKey(),
dataSourceProperty.getValue());
Review comment:
use the key which is removed prefix "property.” from
dataSourceProperty.getKey()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
