imay commented on a change in pull request #1255: Change strategy of incorrect
data
URL: https://github.com/apache/incubator-doris/pull/1255#discussion_r290767524
##########
File path: be/src/exec/broker_scanner.cpp
##########
@@ -585,24 +601,35 @@ bool BrokerScanner::fill_dest_tuple(const Slice& line,
Tuple* dest_tuple, MemPoo
continue;
}
- ExprContext* ctx = _dest_expr_ctx[ctx_idx++];
+ ExprContext* ctx = _dest_expr_ctx[ctx_idx];
void* value = ctx->get_value(_src_tuple_row);
if (value == nullptr) {
- if (slot_desc->is_nullable()) {
- dest_tuple->set_null(slot_desc->null_indicator_offset());
- continue;
- } else {
+ if (_strict_mode &&
!_src_tuple->is_null(slot_desc->null_indicator_offset())
+ && !_has_expr_columns[ctx_idx++]) {
Review comment:
_strict_mode && _has_expr_clumns[] && is_null
And don't add ctx_id++ here.
First this predicate may not be executed, and it is difficult to do things
right
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
