imay commented on a change in pull request #1255: Change strategy of incorrect
data
URL: https://github.com/apache/incubator-doris/pull/1255#discussion_r291075205
##########
File path: be/src/exec/broker_scanner.cpp
##########
@@ -585,24 +602,37 @@ bool BrokerScanner::fill_dest_tuple(const Slice& line,
Tuple* dest_tuple, MemPoo
continue;
}
- ExprContext* ctx = _dest_expr_ctx[ctx_idx++];
+ ExprContext* ctx = _dest_expr_ctx[ctx_idx];
void* value = ctx->get_value(_src_tuple_row);
if (value == nullptr) {
- if (slot_desc->is_nullable()) {
- dest_tuple->set_null(slot_desc->null_indicator_offset());
- continue;
- } else {
+ if (_strict_mode &&
!_src_tuple->is_null(slot_desc->null_indicator_offset())
Review comment:
slot_desc is dest tuple descriptor, what you need is a src tuple descriptor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
