kangpinghuang commented on a change in pull request #1346: Add column reader
writer for segment V2
URL: https://github.com/apache/incubator-doris/pull/1346#discussion_r296570993
##########
File path: be/src/olap/rowset/segment_v2/encoding_info.cpp
##########
@@ -33,14 +34,33 @@ struct TypeEncodingTraits { };
template<FieldType type>
struct TypeEncodingTraits<type, PLAIN_ENCODING> {
- static Status create_page_builder(PageBuilder** builder) {
+ static Status create_page_builder(const PageBuilderOptions& opts,
PageBuilder** builder) {
return Status::OK();
}
- static Status create_page_decoder(PageDecoder** decoder) {
+ static Status create_page_decoder(const Slice& data, PageDecoder**
decoder) {
Review comment:
Here should add PageDecoderOptions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
