kangpinghuang commented on a change in pull request #1346: Add column reader
writer for segment V2
URL: https://github.com/apache/incubator-doris/pull/1346#discussion_r296076877
##########
File path: be/src/olap/rowset/segment_v2/encoding_info.h
##########
@@ -40,23 +42,28 @@ class EncodingInfo {
// Get default type info
static EncodingTypePB get_default_encoding_type(const TypeInfo* type_info);
- Status create_page_builder(PageBuilder** builder) const {
- return _create_buidler_func(builder);
+ Status create_page_builder(const PageBuilderOptions& opts, PageBuilder**
builder) const {
+ return _create_buidler_func(opts, builder);
Review comment:
misspell?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
