morningman commented on a change in pull request #1471: Planner support push 
down predicates past agg, win and sort
URL: https://github.com/apache/incubator-doris/pull/1471#discussion_r303291320
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
 ##########
 @@ -1545,5 +1625,188 @@ private void 
materializeInlineViewResultExprForCrossJoinOrCountStar(InlineViewRe
         }
     }
 
+    /**
+     
------------------------------------------------------------------------------
+     */
+    /**
+     * Push down predicates rules
+     */
+
+    private void pushDownPredicates(Analyzer analyzer, SelectStmt stmt) throws 
AnalysisException {
 
 Review comment:
   Could add some comment to these functions?
   There is no comment at all?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to