chaoyli commented on a change in pull request #1561: Unify Field and
ColumnSchema in Storage
URL: https://github.com/apache/incubator-doris/pull/1561#discussion_r308288000
##########
File path: be/src/olap/schema.h
##########
@@ -143,24 +154,30 @@ class Schema {
*reinterpret_cast<bool*>(row + _col_offsets[index]) = true;
}
- void set_not_null(int index, char*row) const {
+ void set_not_null(int index, char* row) const {
*reinterpret_cast<bool*>(row + _col_offsets[index]) = false;
}
+ void set_is_null(void* row, uint32_t cid, bool is_null) const {
Review comment:
The parameter is not match with set_not_null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
