chaoyli commented on a change in pull request #1561: Unify Field and
ColumnSchema in Storage
URL: https://github.com/apache/incubator-doris/pull/1561#discussion_r308297293
##########
File path: be/src/olap/row_cursor.h
##########
@@ -160,28 +115,44 @@ class RowCursor {
inline size_t get_fixed_len() const { return _fixed_len; }
inline size_t get_variable_len() const { return _variable_len; }
+ // Get column nullable pointer with column id
+ // TODO(zc): make this return const char*
+ char* nullable_cell_ptr(uint32_t cid) const {
+ return _fixed_buf + _schema->column_offset(cid);
+ }
+ char* cell_ptr(uint32_t cid) const {
Review comment:
cell_ptr() in RowCursor not include null indicator, in ColumnBlock include
null indicator.
The two place are not consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
