yiguolei commented on a change in pull request #1576: Change cumulative
compaction for decoupling storage from compution
URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r310465133
##########
File path: be/src/olap/tablet.cpp
##########
@@ -933,4 +972,20 @@ OLAPStatus Tablet::set_partition_id(int64_t partition_id)
{
return _tablet_meta->set_partition_id(partition_id);
}
+void
Tablet::pick_candicate_rowsets_to_cumulative_compaction(std::vector<RowsetSharedPtr>*
candidate_rowsets) {
+ for (auto& it : _rs_version_map) {
+ if (it.first.first > _cumulative_point) {
+ candidate_rowsets->push_back(it.second);
Review comment:
add first == second here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
