yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r311829801
########## File path: be/src/olap/tablet_manager.cpp ########## @@ -301,6 +301,11 @@ OLAPStatus TabletManager::create_tablet(const TCreateTabletReq& request, LOG(WARNING) << "fail to create tablet. res=" << res; } + // call calculate_cumulative_point() manually. + // If not, cumulative_point will set to minus one + // when init tablet during create tablet. + RETURN_NOT_OK(tablet->calculate_cumulative_point()); + Review comment: If calculate method is called in two cases, it's better to call it during cumulative compaction. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org