imay commented on a change in pull request #1576: Change cumulative compaction
for decoupling storage from compution
URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r311406307
##########
File path: be/src/olap/storage_engine.cpp
##########
@@ -598,27 +585,13 @@ void StorageEngine::perform_base_compaction(DataDir*
data_dir) {
TabletSharedPtr best_tablet =
_tablet_manager->find_best_tablet_to_compaction(CompactionType::BASE_COMPACTION,
data_dir);
if (best_tablet == nullptr) { return; }
- DorisMetrics::base_compaction_request_total.increment(1);
Review comment:
why do you drop this metrics?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
