imay commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r312726647
########## File path: be/src/olap/compaction.h ########## @@ -0,0 +1,89 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#ifndef DORIS_BE_SRC_OLAP_COMPACTION_H +#define DORIS_BE_SRC_OLAP_COMPACTION_H + +#include <vector> + +#include "olap/merger.h" +#include "olap/olap_common.h" +#include "olap/olap_define.h" +#include "olap/storage_engine.h" +#include "olap/tablet.h" +#include "olap/tablet_meta.h" +#include "olap/utils.h" +#include "rowset/alpha_rowset_writer.h" +#include "rowset/rowset_id_generator.h" + +namespace doris { + +class Merger; + +// This class is a base class for compaction. +// The entrance of this class is compact() +// Any compaction should go through four procedures. +// 1. pick rowsets satisfied to compact +// 2. do compaction +// 3. modify rowsets +// 4. gc unused rowstes +class Compaction { +public: + Compaction(TabletSharedPtr tablet); + virtual ~Compaction(); + Review comment: Only keep needed function as public, make others private/protected ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
