imay commented on a change in pull request #1617: Add PreAgg Hint
URL: https://github.com/apache/incubator-doris/pull/1617#discussion_r312728326
##########
File path: fe/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
##########
@@ -327,6 +325,10 @@ private void turnOffPreAgg(AggregateInfo aggInfo,
SelectStmt selectStmt, Analyze
break;
}
+ if (((OlapScanNode)root).getForceOpenPreAgg()) {
+ return;//OlapScanNode has be forced opened PreAgg then the
function return directly.
Review comment:
why return?
you should call olapNode.setIsPreAggregation(true, null);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
