imay commented on a change in pull request #1617: Add PreAgg Hint URL: https://github.com/apache/incubator-doris/pull/1617#discussion_r312728141
########## File path: fe/src/main/cup/sql_parser.cup ########## @@ -338,6 +338,7 @@ nonterminal ArrayList<String> opt_plan_hints; nonterminal ArrayList<String> opt_sort_hints; nonterminal Expr sign_chain_expr; nonterminal Qualifier union_op; +nonterminal String opt_agg_open_hints; Review comment: change this name? This can be hint for other purpose. I think it should be a List<Sting>, cause we can support other hints later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
